Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch 2.1.2 #216

Merged
merged 5 commits into from
Jan 30, 2024
Merged

pytorch 2.1.2 #216

merged 5 commits into from
Jan 30, 2024

Conversation

jjerphan
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Signed-off-by: Julien Jerphanion <[email protected]>
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libtorch' output doesn't have any tests.

@jjerphan
Copy link
Member Author

@conda-forge-admin, please rerender

Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch-cpu-feedstock/actions/runs/7660230636.

@jjerphan jjerphan marked this pull request as ready for review January 26, 2024 15:40
@jjerphan
Copy link
Member Author

@jaimergp: could you repush an empty commit, please?

@jjerphan
Copy link
Member Author

Thank you, @jaimergp.

It seems that one workflow is marked as failed, but it is not possible to access its logs.

Should we rerun all of them?

@jaimergp
Copy link
Member

I've rerun failures once. I think we are close to resource exhaustion and some workers die. Let's give it a 2nd try.

@jjerphan
Copy link
Member Author

I think there is a warning which is duplicated multiple times and which spams the logs showing the job as failing even-though the job itself might not fail.

@isuruf
Copy link
Member

isuruf commented Jan 29, 2024

Yeah, @hmaarrfk has been building that job manually.

@jjerphan
Copy link
Member Author

OK, then is this PR ready for reviews?

@isuruf
Copy link
Member

isuruf commented Jan 29, 2024

Yes

@@ -53,7 +53,7 @@ python:
- 3.8.* *_cpython
- 3.9.* *_cpython
pytorch:
- '2.0'
- '2.1'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might the previous builds for 2.1.0 be compromised?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pin is somewhat ignored. This funny thing is happening in rendering this repo that is odd with the PyTorch pinning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the behaviour of conda build misleading.

@hmaarrfk
Copy link
Contributor

log files for cuda112 + linux:
log_files.zip

@hmaarrfk hmaarrfk merged commit 8d94e72 into conda-forge:main Jan 30, 2024
26 of 27 checks passed
@jjerphan jjerphan deleted the 2.1.2 branch January 30, 2024 13:02
@jjerphan
Copy link
Member Author

Thank you, @hmaarrfk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants