Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libboost 1.82 #42

Closed
wants to merge 2 commits into from
Closed

Rebuild for libboost 1.82 #42

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a341e8
Rebuild for libboost 1.82
regro-cf-autotick-bot Oct 1, 2023
5be0019
MNT: Re-rendered with conda-build 3.26.1, conda-smithy 3.26.3, and co…
regro-cf-autotick-bot Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .ci_support/migrations/boost_cpp_to_libboost.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
migrator_ts: 1695775149
__migrator:
kind: version
migration_number: 1
bump_number: 1
commit_message: "Rebuild for libboost 1.82"
# limit the number of prs for ramp-up
pr_limit: 10
libboost_devel:
- 1.82
# This migration is matched with a piggy-back migrator
# (see https://github.com/regro/cf-scripts/pull/1668)
# that will replace boost-cpp with libboost-devel
boost_cpp:
- 1.82
# same for boost -> libboost-python-devel
libboost_python_devel:
- 1.82
boost:
- 1.82
9 changes: 3 additions & 6 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ source:
sha256: f1d6c208da8ec2945adc8bb1c11b1ae5dcf9f2e75ca22f7cf2928d629fad7711

build:
number: 2
number: 3

requirements:
build:
Expand All @@ -36,11 +36,10 @@ outputs:
- libabseil
- tbb-devel
- mppp >=0.27
- boost-cpp
- libboost-devel
- backtrace # [linux]
run:
- backtrace # [linux]
- {{ pin_compatible('boost-cpp', max_pin='x.x') }}
- __osx >={{ MACOSX_DEPLOYMENT_TARGET|default("10.9") }} # [osx and x86_64]
files:
- lib/libobake*{{ SHLIB_EXT }} # [not win]
Expand All @@ -58,7 +57,7 @@ outputs:
run_exports:
# SO name changes at minor rev bumps.
- {{ pin_subpackage('obake', max_pin='x.x') }}
- {{ pin_compatible('boost-cpp', max_pin='x.x') }}
- {{ pin_compatible('libboost-devel', max_pin='x.x') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not run-export libboost-devel, but (if at all) libboost. That saves 15k headers for users which won't need it.

- {{ pin_compatible('tbb', max_pin=None) }}
- {{ pin_compatible('mppp', max_pin="x.x") }}
- {{ pin_compatible('fmt', max_pin="x") }}
Expand All @@ -75,11 +74,9 @@ outputs:
- tbb-devel
- mppp >=0.27
- fmt
- boost-cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal is almost certainly incorrectly - it happened because the logic of the bot is not smart enough for all corner cases (and the match with boost-cpp in the run-exports messed up the expected counts.

- backtrace # [linux]
run:
- tbb-devel
- {{ pin_compatible('boost-cpp', max_pin='x.x') }}
- backtrace # [linux]
- {{ pin_subpackage("obake", exact=True) }}
- __osx >={{ MACOSX_DEPLOYMENT_TARGET|default("10.9") }} # [osx and x86_64]
Expand Down