Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libabseil20230802_libgrpc157_libprotobuf4234 #41

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update libabseil20230802_libgrpc157_libprotobuf4234.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6140483570, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

The errors look weird to me. There's essentially zero mention of abseil or its types, just some constexpr-ness mismatch between obake and fmt. I guess this might still bubble up through abseil in some obake types though, and it's not the only constexpr problem I've seen with new abseil...

@h-vetinari
Copy link
Member

There's essentially zero mention of abseil or its types, just some constexpr-ness mismatch between obake and fmt.

That might actually be due to obake using C++20, while abseil is still on C++17 (see conda-forge/abseil-cpp-feedstock#45).

@bluescarni
Copy link
Contributor

There's essentially zero mention of abseil or its types, just some constexpr-ness mismatch between obake and fmt.

That might actually be due to obake using C++20, while abseil is still on C++17 (see conda-forge/abseil-cpp-feedstock#45).

Hi @h-vetinari and sorry for the late reply...

I am positive the issue has nothing to do with abseil, rather it is caused by API changes in fmt which I need to address with a new obake release. I will try to get a new release out this week.

Should we keep this open in the meantime?

@h-vetinari
Copy link
Member

I am positive the issue has nothing to do with abseil, rather it is caused by API changes in fmt which I need to address with a new obake release. I will try to get a new release out this week.

Cool, good to know! No big rush from the side of the migration.

Should we keep this open in the meantime?

Yeah, otherwise the migrator wrongly tries to move on. We can easily fix it once there's a new release.

@h-vetinari
Copy link
Member

I will try to get a new release out this week.

Hey @bluescarni, without pressure and any expectation, I just wanted to ask how things are looking for a new obake release?

@h-vetinari
Copy link
Member

Gentle ping @bluescarni about an obake-release that's compatible with fmt 10

@bluescarni
Copy link
Contributor

Sorry for dropping the ball on this, I am swamped this week. I will give it another try this upcoming weekend.

@bluescarni
Copy link
Contributor

@h-vetinari I added a patch that fixes the issue locally for me, let's see how it goes.

@bluescarni bluescarni merged commit 4e5d0da into conda-forge:main Nov 12, 2023
5 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-libabseil20230802_libgrpc157_libprotobuf4234-0-1_h1c54ac branch November 12, 2023 22:00
@h-vetinari
Copy link
Member

Cool, thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants