Fixed pkgconfig files (mostly on Windows)

[peci1]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

This PR imports the fix for issues nih-at/libzip#399 and nih-at/libzip#404 . It is essential for this library working on Windows. This patch should be removed when new upstream release is done, as it will be included.

The current bad pkgconfig file on Windows looks like this:

prefix=D:/Programy/conda-envs/ign8/Library
exec_prefix=${prefix}
bindir=${prefix}/bin
libdir=${prefix}/lib
includedir=${prefix}/include

zipcmp=${bindir}/zipcmp

Name: libzip
Description: library for handling zip archives
Version: 1.10.1
Libs:  -L${libdir} -lzip
Libs.private:  -lzstdadvapi32 -lzstdbzip2 -lzstdbcrypt -lzstdZLIB::ZLIB
Cflags: -I${includedir}

Notice Libs.private contains garbage, making it impossible to build anything against libzip.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[peci1]

@conda-forge-admin, please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libzip-feedstock/actions/runs/6060841097.

[traversaro]

Thanks! Just for curiosity, which downstream project finds libzlib with pkg-config ? Some gz-* library?

[github-actions]

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

• linter: passed
• travis: passed
• azure: passed

Thus the PR was passing and merged! Have a great day!

[traversaro]

Notice Libs.private contains garbage, making it impossible to build anything against libzip.

Note that in theory as we are building shared library the Libs.private could be ignored, unfortunately this is not the case, see conda-forge/conda-forge.github.io#1880 for a related discussion.

[peci1]

Thanks! Just for curiosity, which downstream project finds libzlib with pkg-config ? Some gz-* library?

It got pulled by gz-fuel_tools9, which in turn just uses the macros given by gz-cmake. And these macros prefer pkgconfig over cmake modules.

[peci1]

Notice Libs.private contains garbage, making it impossible to build anything against libzip.

Note that in theory as we are building shared library the Libs.private could be ignored, unfortunately this is not the case, see conda-forge/conda-forge.github.io#1880 for a related discussion.

I agree. It seems to me Libs.private are a much different case than Requires.private. I actually wondered why are all these added to the output of pkg-config --libs libzip even without the --static argument. I actually couldn't figure it out even reading the pkg-config source code...