-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add run dependency on cuda-nvcc when using CUDA 12 #241
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.27.04.08.42
Should work now. Thanks @aktech for fixing this |
What triggered osx-arm testing all of the sudden? @conda-forge-admin, please rerender |
Yes, let's deal with |
Thanks! |
Given that conda-forge/jaxlib-feedstock#241 has been merged, they are not needed anymore
This turned out not to be true, as the fix fixed 12.4.* builds, but all builds are using 12.0.* due to cuda pinned to that version. See conda-forge/cuda-cupti-feedstock#14 . |
jax
has a runtime dependency oncuda-nvcc
. Before CUDA 12, there was nocuda-nvcc
package in conda-forge, so users had to install it in a different way (see https://github.com/google/jax/blob/jaxlib-v0.4.25/docs/installation.md#conda-installation for the jax docs on this, that suggest to installcuda-nvcc
via thenvidia
channel.Since we now also have CUDA 12, the
cuda-nvcc
is available in conda-forge, so in the CUDA 12 case, we can just add a run dependency on it (see https://github.com/google/jax/blob/jaxlib-v0.4.25/setup.py#L132 for a similar dependency in the upstream package).The existing build was also missing a
run
dependency oncuda-cupti
, this will also be solved by this PR as we will build against thecuda-cupti-dev
package that now has the correctrun_exports
(see conda-forge/cuda-cupti-feedstock#9 and conda-forge/cuda-cupti-feedstock#10).Fix #239 .
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)