-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap with drop-in API replacement working on Windows as well #2
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
I was too hasty on pushing "create" button, need to prepare some source patches. Converting to draft... |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please rerender |
@conda-forge/gpustat this is ready for review |
There are some important modifications made here that does not really reflect the current version of gpustat (0.6.0). I am not comfortable merging into the 0.6.0 version of the conda package that has been released more than one year ago now. Can you ask upstream to release a new version and we will just build a new package here once this is done? In the meantime, you should rely on a pip install from pinging @conda-forge/help-python in case they have an opinion different than mine here. |
I can technically revert most of Windows-specific patches, as they were relevant for running the thing on Windows (and won't trigger in the CI). I sure will contact the upstream. |
@hadim |
Agree with the tests and thanks for the work! But my point is we should not change the deps of the version of the package neither add a patch of any sort nor it could break other person pipeline if they rely on this specific version. I am fine merging the added tests, bumping the build number but without the patches and the switch to blessed. For this, I would wait for the upstream release. |
Signed-off-by: Litvinov <[email protected]>
Signed-off-by: Vasily Litvinov <[email protected]>
Signed-off-by: Vasily Litvinov <[email protected]>
Signed-off-by: Vasily Litvinov <[email protected]>
ac0fb8c
to
6bba290
Compare
Rebased off new master, converted into draft for now - waiting for upstream response. |
Thanks, @vnlitvinov for your time and being comprehensive! |
There's been a tag of BTW, saw this PR too late before opening #4, sorry. |
gpustat 1.0.0 supports windows |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Replace
blessings
withblessed
which is an API-compatible fork that works on Windows as well as on other platforms.Upstream
gpustat
has already moved to it but has not made a release yet.