Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ffmpeg7 with QSV #279

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Build ffmpeg7 with QSV #279

wants to merge 2 commits into from

Conversation

hmaarrfk
Copy link
Contributor

Without libvpl one gets:

ERROR: libvpl >= 2.6 not found

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 4, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12223168257. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 8, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12223193899. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 8, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12223456733. Examine the logs at this URL for more detail.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2024

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 8, 2024

We should consider the size implications of this, in its current implementation it adds intel-media-driver, which is 128MB download and extracted it is 450MB, a single file the so file for the iHD_drv_video.so.

@isuruf
Copy link
Member

isuruf commented Dec 10, 2024

We should consider the size implications of this, in its current implementation it adds intel-media-driver, which is 128MB download and extracted it is 450MB, a single file the so file for the iHD_drv_video.so.

You should just strip that file of debug info.

$ ls -alh lib/dri/iHD_drv_video.so 
-rwxr-xr-x 1 isuruf isuruf 423M Nov  3 23:59 lib/dri/iHD_drv_video.so
$ strip lib/dri/iHD_drv_video.so 
$ ls -alh lib/dri/iHD_drv_video.so 
-rwxr-xr-x 1 isuruf isuruf 39M Dec 10 03:13 lib/dri/iHD_drv_video.so

@hmaarrfk
Copy link
Contributor Author

Thanks I removed 2 occurances I could find of the -g flag and size is down to 43MB.

ls -lah /home/conda/feedstock_root/build_artifacts/debug_1733803501987/_h_env/lib/dri/iHD_drv_video.so
-rwxr-xr-x 1 conda conda 43M Dec 10 04:27 /home/conda/feedstock_root/build_artifacts/debug_1733803501987/_h_env/lib/dri/iHD_drv_video.so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants