Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python 3.13 #52

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package cytoolz using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@dopplershift
Copy link
Member

I pulled in a patch for the failing tests from pytoolz/cytoolz#205. As explained in pytoolz/cytoolz#206, the failures are due to newer Python versions (not just 3.13) addressing a limitation in inspect.signature, which changed the test results. Not sure how we feel about bringing in a PR, but the repo does seem a little unresponsive and this will hold up the 3.13 migration for dask.

@dopplershift dopplershift force-pushed the rebuild-python313-0-1_h55a152 branch from bd43543 to 142d00b Compare September 25, 2024 21:50
@dopplershift
Copy link
Member

Ok, switched to pytoolz/cytoolz#206 since that fixes some issues unique to Python 3.13. Same caveats about being PR only still apply.

@dopplershift
Copy link
Member

Rebased on top of the 1.0 release, which eliminated the need for the patch.

@jakirkham
Copy link
Member

Thanks Ryan! 🙏

recipe/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Oct 7, 2024
@github-actions github-actions bot merged commit 37f7823 into conda-forge:main Oct 7, 2024
32 checks passed
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python313-0-1_h55a152 branch October 7, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants