Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-parallelcluster v3.6.0 (take 2) #92

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

aws-parallelcluster v3.6.0 (take 2) #92

wants to merge 3 commits into from

Conversation

nyetsche
Copy link

@nyetsche nyetsche commented Oct 17, 2023 •
edited
Loading

There was an attempt to package 3.6.0 in #82 - hopefully this one passes all the checks.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@nyetsche
Copy link
Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 17, 2023 17:19
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.27.1, and co…
4dabe2e 
…nda-forge-pinning 2023.10.17.07.56.56
@nyetsche
return pyyaml pin to 5.3.1
b6ee4b0 
the move to 6.0.1 was done here:
aws/aws-parallelcluster#5509 as part of the 3.7
release

but was possibly unnecessary. it has been reversed at
aws/aws-parallelcluster#5719 after the issue
aws/aws-parallelcluster#5714 was described
@enrico-usai
Copy link
Contributor

enrico-usai commented Oct 18, 2023 •
edited
Loading

Hi @nyetsche thanks for the contribution, but we are already at version 3.7.2.
With your patch we're moving back to 3.6.0.

We started introducing pcluster 3.x on Conda from version 3.6.1: https://anaconda.org/conda-forge/aws-parallelcluster/files, we can avoid 3.6.0.

I'm going to close this patch but please let me know if you have any question/comment or if I missed something.
thanks

@nyetsche
Copy link
Author

Hi @enrico-usai - yes, my organization uses pcluster-3.6.0, as well as the more recent versions. Our extant clusters aren't going to be upgraded anytime soon. Standardizing on conda for installation and switching environments (all the different versions) is helpful.

Is there something about my PR that precludes creating a 3.6.0 version, but not making it the default?

@enrico-usai enrico-usai reopened this Oct 18, 2023
@enrico-usai
Copy link
Contributor

Thanks @nyetsche for the explanation.
I reopened the patch let's ask @notestaff if it's possible to merge it without breaking the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demartinofra demartinofra Awaiting requested review from demartinofra demartinofra is a code owner

@dreambeyondorange dreambeyondorange Awaiting requested review from dreambeyondorange dreambeyondorange is a code owner

@enrico-usai enrico-usai Awaiting requested review from enrico-usai enrico-usai is a code owner

@hanwen-pcluste hanwen-pcluste Awaiting requested review from hanwen-pcluste hanwen-pcluste is a code owner

@lukeseawalker lukeseawalker Awaiting requested review from lukeseawalker lukeseawalker is a code owner

@notestaff notestaff Awaiting requested review from notestaff notestaff is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyetsche @enrico-usai