Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show other snappable lines during grid ruler resize #6722

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Dec 12, 2024

Problem:

During grid ruler resize the other "snappable" lines for the axis should be shown on the grid instead of the full grid placeholders.

Fix:

This PR extends the previous snapline code to include lines for the other columns/rows in the current axis, because the regular placeholders would show too much information.

As a future extension it would make sense to show the lines in between any gap that may have been defined on the axis.

Before After
Kapture 2024-12-12 at 17 39 11 Kapture 2024-12-12 at 17 37 59

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Fixes #6721

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Try me

Copy link

relativeci bot commented Dec 12, 2024

#15422 Bundle Size — 58.22MiB (~+0.01%).

3f79745(current) vs d1d46c1 master#15416(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#15422
     Baseline
#15416
Regression  Initial JS 41.19MiB(~+0.01%) 41.19MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.25% 18.12%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4190 4190
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.24% 27.24%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#15422
     Baseline
#15416
Regression  JS 58.21MiB (~+0.01%) 58.21MiB
Improvement  HTML 9.4KiB (-0.21%) 9.42KiB

Bundle analysis reportBranch feat/other-snap-lines-during-gri...Project dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi merged commit 50ee1f0 into master Dec 13, 2024
13 checks passed
@ruggi ruggi deleted the feat/other-snap-lines-during-grid-resize-rulers branch December 13, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show other snappable lines during grid ruler resize
4 participants