Ruler marker resize for non-stretching grid items #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15358 Bundle Size — 58.2MiB (~+0.01%).feb8279(current) vs d1d46c1 master#15351(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15358 |
Baseline #15351 |
|
|---|---|---|
 Initial JS |
41.17MiB(~+0.01%) |
41.17MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.24% |
18.11% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4189 |
4189 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.24% |
27.24% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15358 |
Baseline #15351 |
|
|---|---|---|
| JS |
58.19MiB (~+0.01%) |
58.19MiB |
| HTML |
9.4KiB (-0.21%) |
9.42KiB |
Bundle analysis report Branch feat/ruler-resize-fixed Project dashboard
Generated by RelativeCI Documentation Report issue
bkrmendy
approved these changes
Dec 4, 2024
ruggi
commented
Dec 4, 2024
| const gap = gridMetadata.specialSizeMeasurements.gap | ||
| gridElement.style.gap = gap == null ? 'initial' : `${gap}px` | ||
| } else { | ||
| const hasRowGap = gridMetadata.specialSizeMeasurements.rowGap != null |
There was a problem hiding this comment.
this is a fix tangential to this PR, the problem is that gap itself might be null even if rowGap and columnGap are defined - the example is a configuration with uneven row/col gaps.
seanparsons
approved these changes
Dec 4, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** It should be possible to resize non-stretching grid items via the ruler markers. **Fix:** Because of how grids are rendered, similarly to what happened in #6691, we need to calculate the rendered dimensions of grid _cells_ (not their contained items!) after they are rendered, since for non-stretching grid items their dimensions (via `getGridChildCellCoordBoundsFromCanvas`) don't match the ones of the cell(s) they are configured to target. This PR uses the logic introduced in #6691 to calculate the size of a grid cell starting from its item, and uses that to correctly place the ruler markers for non-stretching items. **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode Fixes #6695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It should be possible to resize non-stretching grid items via the ruler markers.
Fix:
Because of how grids are rendered, similarly to what happened in #6691, we need to calculate the rendered dimensions of grid cells (not their contained items!) after they are rendered, since for non-stretching grid items their dimensions (via
getGridChildCellCoordBoundsFromCanvas) don't match the ones of the cell(s) they are configured to target.This PR uses the logic introduced in #6691 to calculate the size of a grid cell starting from its item, and uses that to correctly place the ruler markers for non-stretching items.
Manual Tests:
I hereby swear that:
Fixes #6695