Respect spans when resizing grid cells #6685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15303 Bundle Size — 58.12MiB (~+0.01%).6be5569(current) vs d1d46c1 master#15294(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15303 |
Baseline #15294 |
|
|---|---|---|
 Initial JS |
41.09MiB(~+0.01%) |
41.09MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.19% |
18.07% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4174 |
4174 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.28% |
27.28% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15303 |
Baseline #15294 |
|
|---|---|---|
| JS |
58.11MiB (~+0.01%) |
58.11MiB |
| HTML |
9.4KiB (-0.21%) |
9.42KiB |
Bundle analysis report Branch fix/grid-cell-resize-spans Project dashboard
Generated by RelativeCI Documentation Report issue
gbalint
reviewed
Nov 27, 2024
| const elementGridPropertiesFromProps = | ||
| selectedElementMetadata.specialSizeMeasurements.elementGridPropertiesFromProps | ||
|
|
||
| const width = |
There was a problem hiding this comment.
I don't like the term width/height because I'm always mistaken that it is a geometrical width/height (in pixels). Is there a better name for this? Maybe columnCount and rowCount
There was a problem hiding this comment.
makes total sense, fixed in 6be5569 (#6685)
gbalint
approved these changes
Nov 27, 2024
liady
approved these changes
Nov 27, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Resizing grid cells always forces explicit numerical placement pins, chomping any `span`s that may have been defined on the cell. **Fix:** After determining the right numerical positions for the resized cell bounds, do a normalization pass so that the new grid props are rewritten to respect the new bounds but also to express them with `spans` if the original pins were spans in the first place. For example, assuming enlarging to the right by 1 cell: | Initial | Result | |--------|----------| | `gridColumn: span 2` | `gridColumn: span 3` | | `gridColumn 3 / span 2` | `gridColumn: 3 / span 3` | **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode Fixes #6683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Resizing grid cells always forces explicit numerical placement pins, chomping any
spans that may have been defined on the cell.Fix:
After determining the right numerical positions for the resized cell bounds, do a normalization pass so that the new grid props are rewritten to respect the new bounds but also to express them with
spansif the original pins were spans in the first place.For example, assuming enlarging to the right by 1 cell:
gridColumn: span 2gridColumn: span 3gridColumn 3 / span 2gridColumn: 3 / span 3Manual Tests:
I hereby swear that:
Fixes #6683