Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the resize corner handles in the dark theme. #6673

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

seanparsons
Copy link
Contributor

Problem:
The resize corner handles look like empty white boxes in the dark theme.

Fix:
Took the colours from the light theme and copied them into the dark theme.

Commit Details:

  • Changed the canvasControlsSizeBoxShadowColor20 and canvasControlsSizeBoxShadowColor50 theme properties.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Fixes #6658

Copy link
Contributor

@liady liady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Try me

Copy link

relativeci bot commented Nov 21, 2024

#15254 Bundle Size — 58.11MiB (~-0.01%).

e716893(current) vs d1d46c1 master#15252(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#15254
     Baseline
#15252
Improvement  Initial JS 41.08MiB(~-0.01%) 41.08MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.17% 18.05%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4172 4172
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.28% 27.28%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#15254
     Baseline
#15252
Improvement  JS 58.1MiB (~-0.01%) 58.1MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/resize-handles-dark-themeProject dashboard


Generated by RelativeCIDocumentationReport issue

@bkrmendy
Copy link
Contributor

Looks great!

@seanparsons seanparsons merged commit 1b27ff8 into master Nov 22, 2024
17 checks passed
@seanparsons seanparsons deleted the fix/resize-handles-dark-theme branch November 22, 2024 11:01
liady pushed a commit that referenced this pull request Dec 13, 2024
- Changed the `canvasControlsSizeBoxShadowColor20` and
`canvasControlsSizeBoxShadowColor50` theme properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The resize corners don't show up the same way in the dark theme as they do in the light theme.
5 participants