Grid ruler marker labels #6664
Merged
Grid ruler marker labels #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15242 Bundle Size — 58.1MiB (~+0.01%).41c9911(current) vs d1d46c1 master#15230(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15242 |
Baseline #15230 |
|
|---|---|---|
 Initial JS |
41.07MiB(~+0.01%) |
41.07MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.45% |
18.04% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4171 |
4171 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.29% |
27.29% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15242 |
Baseline #15230 |
|
|---|---|---|
| JS |
58.09MiB (~+0.01%) |
58.09MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/ruler-marker-labels Project dashboard
Generated by RelativeCI Documentation Report issue
seanparsons
reviewed
Nov 20, 2024
|
|
||
| // This function returns the amount of pixels used to adjust the position of | ||
| // individual ruler markers, which need specific skews based on their shape. | ||
| function skewMarkerPosition( |
There was a problem hiding this comment.
All the comments, love it.
seanparsons
approved these changes
Nov 20, 2024
|
put the markers behind a FF in |
balazsbajorics
approved these changes
Nov 21, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Ruler markers should show a label with the respective CSS value when hovered. **Fix:** 1. Show labels with the printed pin CSS when hovering a ruler marker. For line names, show the line name. For named spans, show `span the-area`. 2. Adjust the markers so they respect the verbatim CSS without special treatment for span-end/start (which we could revisit in the future) 3. Adjust (and make more readable) the invididual marker skew values, which need to be customized in a bunch of combinations (it's subtle, but it's there!). I ended up using a bunch of named conditions, which after some tinkering felt much more readable than a cluster of ifs or switches. Better ideas are more than welcome tho! 🤗 https://github.com/user-attachments/assets/063adeb5-0b09-4a09-8603-77448bfd0cb2 | Config | Before | After | |--------|---------|-----------| | `gridColumn: auto`, `gridRow: auto` | <img width="1120" alt="Screenshot 2024-11-20 at 15 30 23" src="https://github.com/user-attachments/assets/c2d2b355-0312-46f4-a34c-f10f4619ddb8"> | <img width="1120" alt="Screenshot 2024-11-20 at 15 30 20" src="https://github.com/user-attachments/assets/a733ca4c-1d77-4d26-925e-8ce4161a3989"> | | `gridColumn: 3`, `gridRow: 1` | <img width="1120" alt="Screenshot 2024-11-20 at 15 30 36" src="https://github.com/user-attachments/assets/b5365ca3-9d2b-4c26-ab32-1811bbf82cb4"> | <img width="1120" alt="Screenshot 2024-11-20 at 15 30 35" src="https://github.com/user-attachments/assets/ae8a1a1c-67a5-466a-a46c-233f98553705"> | | `gridColumn: span 2 / 4`, `gridRow: span 3` | <img width="1133" alt="Screenshot 2024-11-20 at 15 35 51" src="https://github.com/user-attachments/assets/dbb8d3e3-89ef-4262-90df-f222bb828c83"> | <img width="1133" alt="Screenshot 2024-11-20 at 15 35 50" src="https://github.com/user-attachments/assets/018bd102-7331-4fbb-8ba6-8ab3316d4464"> | <img width="1120" alt="Screenshot 2024-11-20 at 15 31 22" src="https://github.com/user-attachments/assets/83057672-e2e5-4307-91ab-bd1a01e8a520"> <img width="1120" alt="Screenshot 2024-11-20 at 15 31 27" src="https://github.com/user-attachments/assets/4bb71dab-d3d6-46e7-b6ec-6e10a726ae7e"> <img width="1133" alt="Screenshot 2024-11-20 at 15 31 35" src="https://github.com/user-attachments/assets/453040c3-7151-4ff8-bfc8-73ed9925307b"> **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode Fixes #6663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Ruler markers should show a label with the respective CSS value when hovered.
Fix:
span the-area.Screen.Recording.2024-11-20.at.15.41.18.mov
gridColumn: auto,gridRow: autogridColumn: 3,gridRow: 1gridColumn: span 2 / 4,gridRow: span 3Manual Tests:
I hereby swear that:
Fixes #6663