Reparenting sets the elements to re-render correctly. #6361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `applyGridReparent` invokes `setElementsToRerenderCommand`. - `baseFlexReparentToAbsoluteStrategy` invokes `setElementsToRerenderCommand`.
seanparsons
requested review from
gbalint,
Rheeseyb,
ruggi,
balazsbajorics,
liady and
bkrmendy
seanparsons
changed the title
#14210 Bundle Size — 62.62MiB (~+0.01%).8c5fcba(current) vs 916e8b9 master#14209(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14210 |
Baseline #14209 |
|
|---|---|---|
 Initial JS |
45.75MiB(~+0.01%) |
45.75MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.68% |
21.66% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4385 |
4385 |
| Duplicate Modules |
523 |
523 |
| Duplicate Code |
31.65% |
31.65% |
| Packages |
472 |
472 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14210 |
Baseline #14209 |
|
|---|---|---|
| JS |
62.61MiB (~+0.01%) |
62.61MiB |
| HTML |
11.12KiB (-0.32%) |
11.16KiB |
Bundle analysis report Branch performance/reparent-elements-to... Project dashboard
Generated by RelativeCI Documentation Report issue
ruggi
approved these changes
Sep 13, 2024
Rheeseyb
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When reparenting, sometimes the strategy is not invoking
setElementsToRerenderCommand.Fix:
I ran all the tests with some added instrumentation that captures any strategies that weren't including
setElementsToRerenderCommandin their output commands. For any that weren't it was added.Commit Details:
applyGridReparentinvokessetElementsToRerenderCommand.baseFlexReparentToAbsoluteStrategyinvokessetElementsToRerenderCommand.Manual Tests:
I hereby swear that:
Fixes #6260