fix(number-input): clamp mouse movements as well when value is clamped #6331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Today when scrubbing the value on mouse movement we still keep track of the original movement delta, causing an issue where it's hard to return after passing the thresholds
Monosnap.screencast.2024-09-06.16-46-13.mp4
Fix:
Keep track of the clamped mouse movement as well. This required adding a way to invert our
calculateDragDelta
function, in order to retrieve the "clamped" mouse movements after clamping the total value.Monosnap.screencast.2024-09-06.16-36-20.mp4
Manual Tests:
I hereby swear that:
Fixes #6299