Keep grid rearrange shadow inside container #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanparsons
approved these changes
Aug 29, 2024
#14017 Bundle Size — 62.54MiB (~+0.01%).47c5652(current) vs 916e8b9 master#13980(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14017 |
Baseline #13980 |
|
|---|---|---|
 Initial JS |
45.67MiB(~+0.01%) |
45.67MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.63% |
21.56% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4377 |
4377 |
| Duplicate Modules |
519 |
519 |
| Duplicate Code |
31.63% |
31.63% |
| Packages |
472 |
472 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14017 |
Baseline #13980 |
|
|---|---|---|
| JS |
62.53MiB (~+0.01%) |
62.52MiB |
| HTML |
11.05KiB (-0.33%) |
11.09KiB |
Bundle analysis report Branch feat/grid-shadow-inside-containe... Project dashboard
Generated by RelativeCI Documentation Report issue
liady
reviewed
Sep 2, 2024
| }, [features, initialShadowFrame, interactionData, shadow, hoveringStart, mouseCanvasPosition]) | ||
| // make sure the shadow is displayed only inside the grid container bounds | ||
| function wrapCoord(c: number, min: number, max: number, shadowSize: number) { | ||
| return Math.min(Math.max(c, min), max - shadowSize) |
liady
reviewed
Sep 2, 2024
| @@ -618,6 +620,20 @@ export const GridControls = controlForStrategyMemoized<GridControlsProps>(({ tar | |||
|
|
|||
| const gridPath = optionalMap(EP.parentPath, shadow?.elementPath) | |||
|
|
|||
| const gridFrame = React.useMemo(() => { | |||
There was a problem hiding this comment.
we can maybe take padding here into consideration (so that the shadow won't get over the paddings)
There was a problem hiding this comment.
true, I tried it when writing the code and it makes sense too – I just did not know which was best tbh, so I just went with the minimum option, but I guess it's easy to change if we find that it would feel better being "stuck to the inner grid" 🤔
liady
approved these changes
Sep 2, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** When rearranging grid elements, the shadow can go anywhere the mouse goes, making it seem like an absolute move. **Fix:** Wrap the shadow coords so they are restricted to the grid container bounds. | Before | After | |----------|--------------| |  |  | Fixes #6272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When rearranging grid elements, the shadow can go anywhere the mouse goes, making it seem like an absolute move.
Fix:
Wrap the shadow coords so they are restricted to the grid container bounds.
Fixes #6272