Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show siblings control for grid cells #6252

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Aug 21, 2024

Problem:

The siblings control is too noisy for grid cells.

Fix:

Disable that control for grid cells.

Before After
Screenshot 2024-08-21 at 18 57 36 Screenshot 2024-08-21 at 18 57 04

Fixes #6251

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Try me

Copy link

relativeci bot commented Aug 21, 2024

#13896 Bundle Size — 62.49MiB (~+0.01%).

bc3a35e(current) vs 6339ece master#13891(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#13896
     Baseline
#13891
Regression  Initial JS 45.63MiB(+0.01%) 45.62MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.52% 22.16%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4373 4373
No change  Duplicate Modules 519 519
Change  Duplicate Code 31.65%(+0.03%) 31.64%
No change  Packages 472 472
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13896
     Baseline
#13891
Regression  JS 62.48MiB (~+0.01%) 62.48MiB
Improvement  HTML 11.05KiB (-0.33%) 11.09KiB

Bundle analysis reportBranch fix/grid-cell-disable-siblings-c...Project dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi merged commit 57c307a into master Aug 22, 2024
16 checks passed
@ruggi ruggi deleted the fix/grid-cell-disable-siblings-control branch August 22, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't show siblings control for grid cells
3 participants