Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the four-sides order for the split input control #6221

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Aug 9, 2024

Problem:
the order of the padding controls is incorrect, it follows the order of the border radius controls but should be a bit different.
this is the first part of #6140

Fix:
allow changing the order of the padding controls without changing the order of the border controls (passing it from outside)
Image

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #6220 that was extracted from #6140

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Try me

Copy link

relativeci bot commented Aug 9, 2024

#13795 Bundle Size — 62.63MiB (~+0.01%).

1d926c0(current) vs 6339ece master#13791(baseline)

Warning

Bundle contains 71 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13795
     Baseline
#13791
Regression  Initial JS 45.73MiB(~+0.01%) 45.73MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.5% 21.48%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4384 4384
No change  Duplicate Modules 523 523
No change  Duplicate Code 31.59% 31.59%
No change  Packages 473 473
No change  Duplicate Packages 71 71
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13795
     Baseline
#13791
Regression  JS 62.62MiB (~+0.01%) 62.62MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch feat/padding-control-orderProject dashboard


Generated by RelativeCIDocumentationReport issue

@lankaukk lankaukk merged commit 55c100b into master Aug 12, 2024
16 checks passed
@lankaukk lankaukk deleted the feat/padding-control-order branch August 12, 2024 19:31
liady added a commit that referenced this pull request Dec 13, 2024
**Problem:**
the order of the padding controls is incorrect, it follows the order of
the border radius controls but should be a bit different.
this is the first part of #6140

**Fix:**
allow changing the order of the padding controls without changing the
order of the border controls (passing it from outside)

![Image](https://github.com/user-attachments/assets/1a5b3abe-d710-4ee1-8a3c-615fb6b14133)

**Manual Tests:**
I hereby swear that:

- [X] I opened a hydrogen project and it loaded
- [X] I could navigate to various routes in Preview mode

Fixes #6220 that was extracted from #6140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct the order of the split padding input to be Top, Right, Bottom, Left
3 participants