Icons for grid autoflow dropdown #6214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrmendy
approved these changes
Aug 8, 2024
#13785 Bundle Size — 62.63MiB (+0.13%).a1d41dc(current) vs 6339ece master#13783(baseline) Important Bundle introduced 1 duplicate package – View changed duplicate packages Warning Bundle introduced 3 new packages: @radix-ui/react-select, @radix-ui/number, @radix-ui/react-use-previous – View changed packages Bundle metrics
|
| Current #13785 |
Baseline #13783 |
|
|---|---|---|
 Initial JS |
45.73MiB(+0.18%) |
45.65MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
23.78% |
22.15% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4384(+0.09%) |
4380 |
| Duplicate Modules |
523 |
523 |
| Duplicate Code |
31.59%(-0.09%) |
31.62% |
| Packages |
473(+0.85%) |
469 |
| Duplicate Packages |
71(+1.43%) |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13785 |
Baseline #13783 |
|
|---|---|---|
| JS |
62.62MiB (+0.13%) |
62.54MiB |
| HTML |
11.16KiB (-0.34%) |
11.2KiB |
Bundle analysis report Branch feat/grid-autoflow-icons Project dashboard
Generated by RelativeCI Documentation Report issue
liady
approved these changes
Aug 8, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** The grid autoflow dropdown should have meaningful icons. **Fix:** - Add the icons to the dropdown select options - Reorder the values to match intended designs - Add a wrapper for radix-ui's select component in order to be able to use separators/placeholders/etc. https://github.com/user-attachments/assets/7f9ac9c2-9610-4ea9-ba98-a76f77976698 Fixes #6213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The grid autoflow dropdown should have meaningful icons.
Fix:
Screen.Recording.2024-08-08.at.19.01.22.mov
Fixes #6213