remove grid-area on grid prop change
#6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13532 Bundle Size — 62.64MiB (~+0.01%).
Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13532 |
Baseline #13529 |
|
|---|---|---|
 Initial JS |
45.71MiB(~+0.01%) |
45.71MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.56% |
21.54% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4380 |
4380 |
| Duplicate Modules |
525 |
525 |
| Duplicate Code |
31.65% |
31.65% |
| Packages |
469 |
469 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13532 |
Baseline #13529 |
|
|---|---|---|
| JS |
62.63MiB (~+0.01%) |
62.63MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/remove-grid-area-on-adjust Project dashboard
…to fix/remove-grid-area-on-adjust
bkrmendy
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
liady
ruggi
approved these changes
Jul 25, 2024
liady
approved these changes
Jul 25, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Problem If a `grid-area` prop was present in the style prop of an element, we leave it there after the element is resized/moved even though the newly added grid positioning props override the original `grid-area` prop. ## Fix Remove the grid-area prop. Consolidating the shorthand props we add into a `grid-area` prop will come on a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a
grid-areaprop was present in the style prop of an element, we leave it there after the element is resized/moved even though the newly added grid positioning props override the originalgrid-areaprop.Fix
Remove the grid-area prop. Consolidating the shorthand props we add into a
grid-areaprop will come on a follow-up PR.