skip calling getRemixValidPathsGenerationContext if not in remixScene

[balazsbajorics]

Problem:
When resizing a PromiseCard, it takes 7-8 ms to run useGetStoryboardRoot / getValidElementPaths which seems to spend most of its time on Remix matchRoutes.

Diagnosis:
Turns out, we had this three lines of code running for every single element visited during the recursive getValidElementPathsFromElement walk:

const isRemixScene = isRemixSceneElement(element, filePath, projectContents)
    const remixPathGenerationContext = getRemixValidPathsGenerationContext(path)
    if (remixPathGenerationContext.type === 'active' && isRemixScene) {

getRemixValidPathsGenerationContext is not trivially cheap to call, and it only returns a sensible result if path points at a remix scene.

Fix:
Only call getRemixValidPathsGenerationContext if isRemixScene is true.

Now useGetStoryboardRoot only takes 0.7ms instead of 7ms.

Note: 0.7ms still feels excessive to run on every single frame, I'll continue the investigation and make a follow up PR

Manual Tests:
I hereby swear that:

• I opened a hydrogen project and it loaded
• I could navigate to various routes in Preview mode

Fixes #6065

[github-actions]

Try me

[relativeci]

#13356 Bundle Size — 62.66MiB (~+0.01%).

17ca236(current) vs 6339ece master#13355(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics   2 changes 1 regression

	Current #13356	Baseline #13355
Initial JS	45.71MiB(~+0.01%)	45.71MiB
Initial CSS	0B	0B
Cache Invalidation	21.62%	21.6%
Chunks	30	30
Assets	33	33
Modules	4374	4374
Duplicate Modules	524	524
Duplicate Code	31.7%	31.7%
Packages	469	469
Duplicate Packages	70	70

Bundle size by type   2 changes 1 regression 1 improvement

	Current #13356	Baseline #13355
JS	62.65MiB (~+0.01%)	62.65MiB
HTML	11.16KiB (-0.33%)	11.2KiB

---

Bundle analysis report Branch performance/get-valid-paths Project dashboard

[balazsbajorics]

Hide Whitespace recommended