fix(editor): don't create a duplicate import for aliased files #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liady
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
bkrmendy
#13327 Bundle Size — 62.62MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13327 |
Baseline #13325 |
|
|---|---|---|
 Initial JS |
45.68MiB(~+0.01%) |
45.68MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.21% |
21.61% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4350 |
4350 |
| Duplicate Modules |
524 |
524 |
| Duplicate Code |
31.71% |
31.71% |
| Packages |
450 |
450 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13327 |
Baseline #13325 |
|
|---|---|---|
| JS |
62.61MiB (~+0.01%) |
62.61MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/alised-imports Project dashboard
bkrmendy
approved these changes
Jul 11, 2024
gbalint
approved these changes
Jul 11, 2024
liady
added a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Currently when trying to import the same component from an import source that is aliased in the file, we incorrectly recognize it as a different source and create a duplicate import **Fix:** Take the alias mapping into consideration. The heavy lifting was done in the previous prep PR which was to pass this mapping into the `mergeImports` function. **To reproduce/test:** In our sample store project, locate the `Grid` with the six `ProductCard`s, and try to move (simply move) one of the `ProductCard` inside that grid. It used to create a duplicate import. **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Preview mode Fixes #5980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently when trying to import the same component from an import source that is aliased in the file, we incorrectly recognize it as a different source and create a duplicate import
Fix:
Take the alias mapping into consideration. The heavy lifting was done in the previous prep PR which was to pass this mapping into the
mergeImportsfunction.To reproduce/test:
In our sample store project, locate the
Gridwith the sixProductCards, and try to move (simply move) one of theProductCardinside that grid. It used to create a duplicate import.Manual Tests:
I hereby swear that:
Fixes #5980