-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifiers for reparenting and convert to absolute strategies #6054
Merged
gbalint
merged 22 commits into
master
from
feature/modifiers-for-reparent-and-convert-to-absolute
Jul 12, 2024
Merged
Modifiers for reparenting and convert to absolute strategies #6054
gbalint
merged 22 commits into
master
from
feature/modifiers-for-reparent-and-convert-to-absolute
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13346 Bundle Size — 62.66MiB (~+0.01%).
Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
Current #13346 |
Baseline #13341 |
|
---|---|---|
Initial JS | 45.71MiB (~+0.01% ) |
45.71MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 21.62% |
22.26% |
Chunks | 30 |
30 |
Assets | 33 |
33 |
Modules | 4374 |
4374 |
Duplicate Modules | 524 |
524 |
Duplicate Code | 31.7% |
31.7% |
Packages | 469 |
469 |
Duplicate Packages | 70 |
70 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #13346 |
Baseline #13341 |
|
---|---|---|
JS | 62.65MiB (~+0.01% ) |
62.64MiB |
HTML | 11.16KiB (-0.33% ) |
11.2KiB |
Bundle analysis report Branch feature/modifiers-for-reparent-a... Project dashboard
bkrmendy
approved these changes
Jul 11, 2024
seanparsons
approved these changes
Jul 12, 2024
gbalint
deleted the
feature/modifiers-for-reparent-and-convert-to-absolute
branch
July 12, 2024 10:33
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Description:** To make our canvas interactions more predictable I put reparenting and conversion to absolute behind modifier keys: - cmd is needed for reparenting - ctrl is needed for conversion to absolute **Notes:** - Nearly 70 tests were broken (nearly all reparenting and convert-to-absolute tests). In most of the cases I just had to add the necessary modifiers to make the tests work - Insertion relies on reparenting, I needed to modify the draw-to-insert strategy too - cmd disables snapping, so now it is not possible to have snapping during reparenting (I needed to disable the tests for this) - space forces convert to absolute, this is in partial conflict with ctrl, but they are not really the same: without ctrl convert-to-absolute strategies are disabled, but even with ctrl other strategies are still possible, while space really forces convert-to-absolute strategies - when you have a selection, cmd mouse down on a descendant element will change the selection to the descendant. If you don't want that, you need to press cmd after the mouse down. - with ctrl, you always need to press it after mouse down, otherwise the context menu will open - earlier cmd had a special meaning in case of reparenting: it allowed the element to be reparented into a parent which is smaller than the element itself. This distinction doesn't exist anymore, because without pressing cmd there is no reparent at all **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode Fixes #6047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To make our canvas interactions more predictable I put reparenting and conversion to absolute behind modifier keys:
Notes:
Manual Tests:
I hereby swear that:
Fixes #6047