Correctly position grid resize controls. #6044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The grid resize controls had their positioning quickly thrown together and somewhat implemented by eye.
Fix:
As part of this work the two big blocks of code for columns and rows were unified into a single
GridResizing
component.The positions have been better positioned by creating a container element which straddles the center line of the gap and then the control is appropriately justified within that to keep it centered or in the case of the row controls right justified.
It also uses the
CanvasLabel
component to handle most of the work for actually displaying things.Screenshot:
Commit Details:
GridResizing
.GridResizing
component in place of the embedded column and row handling.Manual Tests:
I hereby swear that: