Expand valid Remix cases for route modules. #6042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `getDefaultExportNameAndUidFromFile` to optionally return a uid. Permitting a file that exists with a default export to be included if it doesn't have a `UTOPIA_JSX_COMPONENT` matching that export.
#13267 Bundle Size — 62.51MiB (~-0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13267 |
Baseline #13264 |
|
|---|---|---|
 Initial JS |
45.56MiB(~-0.01%) |
45.56MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.62% |
21.84% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4323 |
4323 |
| Duplicate Modules |
524 |
524 |
| Duplicate Code |
31.74% |
31.74% |
| Packages |
450 |
450 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 2 improvements
| Current #13267 |
Baseline #13264 |
|
|---|---|---|
| JS |
62.5MiB (~-0.01%) |
62.5MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/slightly-widen-remix-possibi... Project dashboard
ruggi
approved these changes
Jul 5, 2024
liady
approved these changes
Jul 9, 2024
bkrmendy
approved these changes
Jul 9, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
- Change `getDefaultExportNameAndUidFromFile` to optionally return a uid. Permitting a file that exists with a default export to be included if it doesn't have a `UTOPIA_JSX_COMPONENT` matching that export.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Sometimes when changing some code the canvas stops rendering in a Remix project.
Cause:
When building the
routeModulesvalue, if a file has a default export but it's impossible to find a matchingUTOPIA_JSX_COMPONENTthen an error occurs in the Remix internals.Fix:
The
getDefaultExportNameAndUidFromFilefunction is partly responsible for populatingrouteModulesand that has been modified to return an optional UID not just an optional result. This means thatrouteModulescan be populated with an entry for a file that has a default export but that export can't be parsed into aUTOPIA_JSX_COMPONENT.Commit Details:
getDefaultExportNameAndUidFromFileto optionally return a uid. Permitting a file that exists with a default export to be included if it doesn't have aUTOPIA_JSX_COMPONENTmatching that export.Manual Tests:
I hereby swear that: