Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize a Grid Element #6038

Merged
merged 22 commits into from
Jul 10, 2024
Merged

Resize a Grid Element #6038

merged 22 commits into from
Jul 10, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jul 3, 2024

Description

This PR adds a strategy and the canvas controls to resize grid elements.

Screen.Recording.2024-07-09.at.15.15.17.mov

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Try me

Copy link

relativeci bot commented Jul 3, 2024

#13301 Bundle Size — 62.62MiB (+0.02%).

c22a06a(current) vs 6339ece master#13297(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#13301
     Baseline
#13297
Regression  Initial JS 45.67MiB(+0.03%) 45.66MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.6% 23.85%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4350(+0.02%) 4349
No change  Duplicate Modules 524 524
Change  Duplicate Code 31.71%(-0.03%) 31.72%
No change  Packages 450 450
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13301
     Baseline
#13297
Regression  JS 62.61MiB (+0.02%) 62.59MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch feature/grid-resize-strategyProject dashboard

@bkrmendy bkrmendy marked this pull request as ready for review July 9, 2024 13:46
Copy link
Contributor

@ruggi ruggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪗

@bkrmendy bkrmendy merged commit 542ddd6 into master Jul 10, 2024
16 checks passed
@bkrmendy bkrmendy deleted the feature/grid-resize-strategy branch July 10, 2024 08:38
liady pushed a commit that referenced this pull request Dec 13, 2024
## Description

This PR adds a strategy and the canvas controls to resize grid elements.




https://github.com/concrete-utopia/utopia/assets/16385508/b048879c-6210-4a30-abbd-4bc310ce7a63



**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Preview mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants