-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize a Grid Element #6038
Merged
Merged
Resize a Grid Element #6038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/grid-resize-strategy
…to feature/grid-resize-strategy
…to feature/grid-resize-strategy
#13301 Bundle Size — 62.62MiB (+0.02%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
Current #13301 |
Baseline #13297 |
|
---|---|---|
Initial JS | 45.67MiB (+0.03% ) |
45.66MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 21.6% |
23.85% |
Chunks | 30 |
30 |
Assets | 33 |
33 |
Modules | 4350 (+0.02% ) |
4349 |
Duplicate Modules | 524 |
524 |
Duplicate Code | 31.71% (-0.03% ) |
31.72% |
Packages | 450 |
450 |
Duplicate Packages | 51 |
51 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #13301 |
Baseline #13297 |
|
---|---|---|
JS | 62.61MiB (+0.02% ) |
62.59MiB |
HTML | 11.16KiB (-0.33% ) |
11.2KiB |
Bundle analysis report Branch feature/grid-resize-strategy Project dashboard
…to feature/grid-resize-strategy
…to feature/grid-resize-strategy
ruggi
reviewed
Jul 9, 2024
ruggi
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪗
editor/src/components/canvas/canvas-strategies/strategies/grid-resize-element-strategy.ts
Outdated
Show resolved
Hide resolved
editor/src/components/canvas/canvas-strategies/strategies/grid-helpers.ts
Outdated
Show resolved
Hide resolved
balazsbajorics
approved these changes
Jul 10, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Description This PR adds a strategy and the canvas controls to resize grid elements. https://github.com/concrete-utopia/utopia/assets/16385508/b048879c-6210-4a30-abbd-4bc310ce7a63 **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a strategy and the canvas controls to resize grid elements.
Screen.Recording.2024-07-09.at.15.15.17.mov
Manual Tests:
I hereby swear that: