Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TargetGridCell from grid move #6033

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Jul 2, 2024

Problem:

The target grid cell during the move strategy relies on a super ugly singleton variable.

Fix:

Get rid of TargetGridCell and instead do the proper adjustments inside the move strategy.

Notes:

  • No behavioral changes
  • The code can be improved further by moving hovering cell data into the editor state (I added a comment in the code) but I left it out of this PR and potentially do it incrementally.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Try me

Copy link

relativeci bot commented Jul 2, 2024

#13249 Bundle Size — 62.5MiB (+0.01%).

4474e36(current) vs 6339ece master#13244(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#13249
     Baseline
#13244
Regression  Initial JS 45.56MiB(+0.01%) 45.55MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.6% 23.8%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4321(+0.05%) 4319
No change  Duplicate Modules 524 524
Change  Duplicate Code 31.74%(-0.03%) 31.75%
No change  Packages 450 450
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13249
     Baseline
#13244
Regression  JS 62.49MiB (+0.01%) 62.48MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch feat/no-target-grid-cellProject dashboard

@ruggi ruggi merged commit d290720 into master Jul 3, 2024
14 checks passed
@ruggi ruggi deleted the feat/no-target-grid-cell branch July 3, 2024 09:56
@ruggi ruggi mentioned this pull request Jul 4, 2024
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**

The target grid cell during the move strategy relies on a super ugly
singleton variable.

**Fix:**

Get rid of `TargetGridCell` and instead do the proper adjustments inside
the move strategy.

**Notes:**
- No behavioral changes
- The code can be improved further by moving hovering cell data into the
editor state (I added a comment in the code) but I left it out of this
PR and potentially do it incrementally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants