fix(requireFn): stub Node's tty module #6026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsbajorics
approved these changes
Jun 27, 2024
#13213 Bundle Size — 62.37MiB (+0.16%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Warning Bundle introduced 3 new packages: @twind/core, @twind/preset-tailwind, @twind/preset-autoprefix – View changed packages Bundle metrics
|
| Current #13213 |
Baseline #13208 |
|
|---|---|---|
 Initial JS |
45.43MiB(+0.23%) |
45.33MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
23.25% |
21.6% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4313(+0.19%) |
4305 |
| Duplicate Modules |
525 |
525 |
| Duplicate Code |
31.79%(-0.16%) |
31.84% |
| Packages |
450(+0.45%) |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13213 |
Baseline #13208 |
|
|---|---|---|
| JS |
62.35MiB (+0.16%) |
62.25MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/tty-stub Project dashboard
gbalint
approved these changes
Jun 27, 2024
liady
added a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Our sample store project uses Tailwind's plugins that are meant to run on Node, requiring `tty` module and breaking the `twind` process **Fix:** Stub the `tty` module. The future complete solution would be to stub all of Node builtin modules, or to run Tailwind on the server or container **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Preview mode Fixes #[ticket_number] (<< pls delete this line if it's not relevant)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Our sample store project uses Tailwind's plugins that are meant to run on Node, requiring
ttymodule and breaking thetwindprocessFix:
Stub the
ttymodule. The future complete solution would be to stub all of Node builtin modules, or to run Tailwind on the server or containerManual Tests:
I hereby swear that:
Fixes #[ticket_number] (<< pls delete this line if it's not relevant)