Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(editor): upgrading twind to support new tailwind 3 syntax #6024

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Jun 26, 2024

This PR upgrades twind to its latest version, adjusts the initialization code, and enables support for Tailwind's dynamic class names:

tailwind.mp4

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Copy link
Contributor

@balazsbajorics balazsbajorics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

Copy link
Contributor

github-actions bot commented Jun 27, 2024

Try me

Copy link

relativeci bot commented Jun 27, 2024

#13211 Bundle Size — 62.37MiB (+0.16%).

b935f8d(current) vs 6339ece master#13208(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Warning

Bundle introduced 3 new packages: @twind/core, @twind/preset-tailwind, @twind/preset-autoprefix – View changed packages

Bundle metrics  Change 5 changes Regression 2 regressions
                 Current
#13211
     Baseline
#13208
Regression  Initial JS 45.43MiB(+0.22%) 45.33MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 23.76% 21.6%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4312(+0.16%) 4305
No change  Duplicate Modules 525 525
Change  Duplicate Code 31.79%(-0.16%) 31.84%
Regression  Packages 450(+0.45%) 448
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13211
     Baseline
#13208
Regression  JS 62.35MiB (+0.16%) 62.25MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch chore/upgrade-twindProject dashboard

@liady liady merged commit 34e0b4b into master Jun 27, 2024
13 checks passed
@liady liady deleted the chore/upgrade-twind branch June 27, 2024 15:24
liady added a commit that referenced this pull request Dec 13, 2024
This PR upgrades [twind](https://twind.style/) to its latest version,
adjusts the initialization code, and enables support for Tailwind's
dynamic class names:

<video
src="https://github.com/concrete-utopia/utopia/assets/7003853/49a8ff00-524d-4fb4-a1c7-9b852ce6f628"></video>



**Manual Tests:**
I hereby swear that:

- [X] I opened a hydrogen project and it loaded
- [X] I could navigate to various routes in Preview mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants