Prevent None Controls From Adding Rows To Inspector. #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added in cases to stop `none` controls from reaching a `RowForControl`. - Changed `RowForControlProps.controlDescription` to `exclude `NoneControlDescription`.
seanparsons
requested review from
gbalint,
ruggi,
balazsbajorics,
benwolfram,
liady and
bkrmendy
ruggi
approved these changes
Jun 20, 2024
#13187 Bundle Size — 62.26MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13187 |
Baseline #13177 |
|
|---|---|---|
 Initial JS |
45.32MiB(~+0.01%) |
45.32MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.6% |
21.58% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4305 |
4305 |
| Duplicate Modules |
525 |
525 |
| Duplicate Code |
31.84% |
31.84% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13187 |
Baseline #13177 |
|
|---|---|---|
| JS |
62.25MiB (~+0.01%) |
62.24MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/prevent-none-controls-from-a... Project dashboard
balazsbajorics
approved these changes
Jun 20, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
…6016) - Added in cases to stop `none` controls from reaching a `RowForControl`. - Changed `RowForControlProps.controlDescription` to `exclude `NoneControlDescription`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Annotations: the 'none' control accidentally creates an empty row.
Fix:
Added conditions to return null for the
nonecases, as well as changing the type forRowForControlto prevent it from being possible to usenonecontrol with it.Commit Details:
nonecontrols from reaching aRowForControl.RowForControlProps.controlDescriptiontoexcludeNoneControlDescription`.Manual Tests:
I hereby swear that:
Fixes #6002