fix(imports): pass import aliases to mergeImports #5995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liady
changed the title
#13271 Bundle Size — 62.51MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13271 |
Baseline #13264 |
|
|---|---|---|
 Initial JS |
45.57MiB(~+0.01%) |
45.56MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.08% |
21.84% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4323 |
4323 |
| Duplicate Modules |
524 |
524 |
| Duplicate Code |
31.74% |
31.74% |
| Packages |
450 |
450 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13271 |
Baseline #13264 |
|
|---|---|---|
| JS |
62.5MiB (~+0.01%) |
62.5MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/alias-imports Project dashboard
liady
changed the title
liady
commented
Jul 8, 2024
| @@ -204,3 +207,20 @@ export function parsedJSONFailure( | |||
| endCol: endCol, | |||
| } | |||
| } | |||
|
|
|||
| export function applyFilePathMappingsToFilePath( | |||
There was a problem hiding this comment.
this only moved as-is from editor/src/core/model/project-file-utils.ts
liady
changed the title
liady
requested review from
gbalint,
seanparsons,
ruggi,
balazsbajorics,
bkrmendy and
Rheeseyb
bkrmendy
approved these changes
Jul 9, 2024
gbalint
approved these changes
Jul 9, 2024
liady
added a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Currently our duplicate import mechanism doesn't consider import aliases, resulting in user actions generating duplicate imports in our sample project. **Fix:** This is the prep PR for passing the aliases to `mergeImports` - since it is running in a worker it cannot access it directly but needs to receive it from the calling context. **This PR only adds `filePathMappings: FilePathMappings` as an argument to `mergeImports` and `renameDuplicateImports`** **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Preview mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently our duplicate import mechanism doesn't consider import aliases, resulting in user actions generating duplicate imports in our sample project.
Fix:
This is the prep PR for passing the aliases to
mergeImports- since it is running in a worker it cannot access it directly but needs to receive it from the calling context.This PR only adds
filePathMappings: FilePathMappingsas an argument tomergeImportsandrenameDuplicateImportsManual Tests:
I hereby swear that: