REPLACE_JSX_ELEMENT to preserve UID of element-to-be-replaced #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13105 Bundle Size — 62.23MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13105 |
Baseline #13104 |
|
|---|---|---|
 Initial JS |
45.3MiB(~+0.01%) |
45.3MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.58% |
0% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4302 |
4302 |
| Duplicate Modules |
523 |
523 |
| Duplicate Code |
31.84% |
31.84% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13105 |
Baseline #13104 |
|
|---|---|---|
| JS |
62.22MiB (~+0.01%) |
62.22MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/replace-element-uid-loss Project dashboard
liady
approved these changes
Jun 17, 2024
gbalint
approved these changes
Jun 17, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** When we Replace This or Replace Everything a selected element, the selection is lost. **Fix:** Turns out the code was straight up cleaning selected views to []. **Commit Details:** - REPLACE_JSX_ELEMENT no longer changes EditorState.selectedViews - REPLACE_JSX_ELEMENT now takes the UID of the old element, and sets it as the UID of the new element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When we Replace This or Replace Everything a selected element, the selection is lost.
Fix:
Turns out the code was straight up cleaning selected views to [].
Commit Details: