Collaborators from the DB #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10589: Bundle Size — 62.25MiB (+0.02%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10589 report View feat/remix-collaborators-db branch activity View project dashboard |
|
Performance test results: |
|
Performance test results: |
1 similar comment
|
Performance test results: |
gbalint
reviewed
Feb 23, 2024
| } | ||
|
|
||
| export function useCollaborators() { | ||
| return useStorage((store) => store.collaborators) | ||
| return useEditorState( | ||
| Substores.restOfEditor, |
There was a problem hiding this comment.
I suggest to add a new Substore for multiplayer related stuff.
Or maybe use an atom for collaborators instead of the editor state (it seems to be quite independent from other parts of the state)
There was a problem hiding this comment.
@gbalint I added a multiplayer substate here fbb22ca (#4946) . would that work for you or would you prefer the atom instead?
ruggi
force-pushed
the
feat/remix-collaborators-db
branch
from
8f72976 to
fbb22ca
Compare
|
Performance test results: |
Rheeseyb
reviewed
Feb 23, 2024
Rheeseyb
approved these changes
Feb 23, 2024
bkrmendy
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4944
This is a followup to #4923, that turns the Utopia DB into the source of truth for collaborators, dropping them from the storage entirely.
.appwhile we don't enable the BFF there too.The
collaboratorsfield in the LB object is kept just as a compatibility measure until we enable the BFF in production. A consequent PR should drop entirely that field and the other related things marked as_DEPRECATED.