Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show objects & arrays in data picker #4887

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Show objects & arrays in data picker #4887

merged 4 commits into from
Feb 13, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Feb 13, 2024 •
edited
Loading

Problem

Object props and array elements are shown in the data picker, but not the objects/arrays themselves

Fix

Show the objects/arrays too

Also

  • add an expect for the items in the data picker popup, so that it's easier to understand which elements are picked in the test

@bkrmendy bkrmendy marked this pull request as ready for review February 13, 2024 14:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Feb 13, 2024

Job #10399: Bundle Size — 61.74MiB (~+0.01%).

644a359(current) vs d299c8d master#10394(baseline)

Warning

Bundle contains 57 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10399		      Baseline
Job #10394
Regression  Initial JS 34.78MiB(~+0.01%) 34.78MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.47% 22.03%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4294 4294
No change  Duplicate Modules 493 493
No change  Duplicate Code 31.01% 31.01%
No change  Packages 455 455
No change  Duplicate Packages 57 57
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10399		      Baseline
Job #10394
Regression  JS 61.73MiB (~+0.01%) 61.72MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10399 report View fix/data-picker-insert-object branch activity View project dashboard

@bkrmendy bkrmendy merged commit b84ecb4 into master Feb 13, 2024
17 of 18 checks passed
@bkrmendy bkrmendy deleted the fix/data-picker-insert-object branch February 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@gbalint gbalint gbalint approved these changes

@seanparsons seanparsons Awaiting requested review from seanparsons

@Rheeseyb Rheeseyb Awaiting requested review from Rheeseyb

@ruggi ruggi Awaiting requested review from ruggi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @balazsbajorics