Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested picker UI for nested objects #4886

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Nested picker UI for nested objects #4886

merged 10 commits into from
Feb 13, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Feb 13, 2024 •
edited
Loading

Adjust the picker UI so it will display nested objects in a nested way (and will also display the objects themselves)
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Feb 13, 2024 •
edited
Loading

Job #10416: Bundle Size — 61.74MiB (~+0.01%).

6089cf1(current) vs d299c8d master#10406(baseline)

Warning

Bundle contains 57 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10416		      Baseline
Job #10406
Regression  Initial JS 34.78MiB(~+0.01%) 34.78MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.47% 20.46%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4294 4294
No change  Duplicate Modules 493 493
No change  Duplicate Code 31.01% 31.01%
No change  Packages 455 455
No change  Duplicate Packages 57 57
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10416		      Baseline
Job #10406
Regression  JS 61.73MiB (~+0.01%) 61.73MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10416 report View feat/nested-ui branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

balazsbajorics
balazsbajorics reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@balazsbajorics balazsbajorics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a nitpick, plus if the names + preview value is too long, something seems to overflow:
image

other than that, looks good to me :)

@liady
Copy link
Contributor Author

liady commented Feb 13, 2024

@balazsbajorics made the UI more responsive for long / nested objects and values. thanks!

@liady liady requested a review from balazsbajorics February 13, 2024 16:42
@liady liady requested a review from bkrmendy February 13, 2024 20:47
@liady liady merged commit e881cbf into master Feb 13, 2024
14 checks passed
@liady liady deleted the feat/nested-ui branch February 13, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbalint gbalint Awaiting requested review from gbalint

@seanparsons seanparsons Awaiting requested review from seanparsons

@Rheeseyb Rheeseyb Awaiting requested review from Rheeseyb

@ruggi ruggi Awaiting requested review from ruggi

@balazsbajorics balazsbajorics Awaiting requested review from balazsbajorics

@bkrmendy bkrmendy Awaiting requested review from bkrmendy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liady @balazsbajorics @bkrmendy