Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put editing comment metadata in useeffect #4875

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Put editing comment metadata in useeffect #4875

merged 1 commit into from
Feb 12, 2024

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Feb 12, 2024 •
edited
Loading

Description:

Do not edit comment metadata directly in the render function

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Feb 12, 2024

Job #10378: Bundle Size — 61.73MiB (~+0.01%).

1a64c6e(current) vs d299c8d master#10377(baseline)

Warning

Bundle contains 57 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10378		      Baseline
Job #10377
Regression  Initial JS 34.78MiB(~+0.01%) 34.77MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.46% 20.44%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4294 4294
No change  Duplicate Modules 493 493
No change  Duplicate Code 31.01% 31.01%
No change  Packages 455 455
No change  Duplicate Packages 57 57
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10378		      Baseline
Job #10377
Regression  JS 61.72MiB (~+0.01%) 61.72MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10378 report View fix/edit-metadata-in-useeffect branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@gbalint gbalint marked this pull request as ready for review February 12, 2024 15:12
@gbalint gbalint merged commit 12aeac1 into master Feb 12, 2024
19 checks passed
@gbalint gbalint deleted the fix/edit-metadata-in-useeffect branch February 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@ruggi ruggi ruggi approved these changes

@Rheeseyb Rheeseyb Rheeseyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gbalint @Rheeseyb @ruggi @balazsbajorics