Scene dragging: do not save new scene comment canvas position in every frame #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10373: Bundle Size — 61.73MiB (~+0.01%).
Warning Bundle contains 57 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10373 report View fix/scene-comment-maintanence branch activity View project dashboard |
bkrmendy
approved these changes
Feb 12, 2024
|
Performance test results: |
| if (isInteraction) { | ||
| return | ||
| } | ||
|
|
||
| threads.forEach(async (t): Promise<void> => { |
There was a problem hiding this comment.
mhmmmmmm, are we directly calling editThreadMetadata from render? shouldn't this part be wrapped in a useEffect?
There was a problem hiding this comment.
This triggers an async liveblocks update but does not wait for it, so it did not seem dangerous to me.
Rheeseyb
approved these changes
Feb 12, 2024
seanparsons
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
CommentMaintainersaves the new global position of scene comments when there is a position change, even during interactions. Updating liveblocks like this is waaay too frequent, and causes bugs and test failures.Fix:
Do not do anything during canvas interactions. The new position is stored right after the interaction is over.