Remix: remove pagination, return all projects #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruggi
changed the title
bkrmendy
approved these changes
Feb 8, 2024
Job #10340: Bundle Size — 62.36MiB (~-0.01%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10340 report View feat/bff-projects-no-pagination branch activity View project dashboard |
|
Performance test results: |
liady
approved these changes
Feb 8, 2024
Rheeseyb
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4861
Problem:
The Remix projects page should not bother with paginating the results, as the client should be doing it (and even for large projects collections it should not be a problem for a long while).
Fix:
Don't limit/offset the query selection (and make sure the content is filtered out!).