Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utopia-remix prettier #4857

Merged
merged 2 commits into from
Feb 8, 2024
Merged

utopia-remix prettier #4857

merged 2 commits into from
Feb 8, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Feb 8, 2024

Fix #4856

This is a followup to #4846 , which removes the eslint-prettier-config dependency and re-formats all the files with the now-inherited prettier config from the root of the repo.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Feb 8, 2024

Job #10317: Bundle Size — 62.35MiB (+0.01%).

299625d(current) vs d6a1d8b master#10312(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10317		      Baseline
Job #10312
Regression  Initial JS 35.39MiB(+0.02%) 35.39MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.23% 20.21%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4407 4407
No change  Duplicate Modules 490 490
No change  Duplicate Code 30.7% 30.7%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10317		      Baseline
Job #10312
Regression  JS 62.34MiB (+0.01%) 62.34MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10317 report View chore/remix-prettier branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit 6441a69 into master Feb 8, 2024
16 checks passed
@ruggi ruggi deleted the chore/remix-prettier branch February 8, 2024 14:39
@ruggi ruggi mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@liady liady liady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make utopia-remix inherit prettier config
3 participants
@ruggi @liady @bkrmendy