Another try to fix flaky remix tests #4834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10223: Bundle Size — 62.35MiB (~+0.01%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10223 report View fix/flaky-remix-tests-2 branch activity View project dashboard |
|
Performance test results: |
|
Performance test results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I wanted to write a new version for the remix navigation tests where we directly use the remix navigation context stored in an atom (instead of clicking on the ui buttons).
It turned out that these new testa are even worse than the original ones: they fail quite frequently even locally. However, if I wait a bit before doing any expectation, they were always successful locally.
It seems to me that this navigation step is more async than we thought, and there is something to wait for (maybe inside the remix implementation?)
This gave me the idea to keep the original tests too, just add some extra
waitcalls, to check if those tests are fixed or not by that.