Prevent Slate errors by unifying the comment popups.

[seanparsons]

Problem:
When adding a comment, an exception is thrown from Slate when confirming the comment contents.

Cause:
In the blur handler of ReactEditor in react-slate, there's a lookup which attempts to find the underling DOM node of the text editor in question. For whatever reason (potentially related to the weakmap it uses under the hood of this) it is unable to match the editor and then throws an exception as a result.

Fix:
Slightly bizarrely the solution was to not have the Composer component be unmounted which has been achieved by unifying the comment handling so that new and existing threads are handled by the same component.

Commit Details:

• Remove NewCommentPopup component.
• Modified the rendering of CommentThread to handle a null for thread.
• Created getLiveblocksEditorElement and triggerAutoFocus utility callbacks.
• Added triggerAutoFocus to onSubmitComment so that creating a new thread auto focuses the new thread edit field.

[github-actions]

Try me

[relativeci]

Job #10090: Bundle Size — 59.82MiB (-0.01%).

5ca5c99(current) vs 3e1b120 master#10084(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics   3 changes 1 improvement

	Current Job #10090	Baseline Job #10084
Initial JS	45.64MiB(-0.02%)	45.65MiB
Initial CSS	0B	0B
Cache Invalidation	23.56%	53.59%
Chunks	27	27
Assets	31	31
Modules	4502(-0.04%)	4504
Duplicate Modules	582	582
Duplicate Code	27.54%	27.54%
Packages	462	462
Duplicate Packages	65	65

Bundle size by type   1 change 1 improvement

	Current Job #10090	Baseline Job #10084
JS	59.81MiB (-0.01%)	59.82MiB
HTML	11.87KiB	11.87KiB

---

View job #10090 report View fix/unify-comment-popup branch activity View project dashboard