Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log waits in puppeteer tests #4789

Merged
merged 7 commits into from
Jan 26, 2024
Merged

log waits in puppeteer tests #4789

merged 7 commits into from
Jan 26, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jan 23, 2024 •
edited
Loading

Description

This PR adds logging to the commenting and collaboration tests, so they are easier to debug if they fail

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 23, 2024 •
edited
Loading

Job #10062: Bundle Size — 62.37MiB (~-0.01%).

3c4609d(current) vs 8f5e3ac master#10060(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
Job #10062		      Baseline
Job #10060
Improvement  Initial JS 45.57MiB(~-0.01%) 45.57MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.94% 19.94%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4395 4395
No change  Duplicate Modules 475 475
No change  Duplicate Code 30.74% 30.74%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #10062		      Baseline
Job #10060
Improvement  JS 62.36MiB (~-0.01%) 62.36MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #10062 report View tests/pupeteer-test-logging branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@bkrmendy bkrmendy marked this pull request as ready for review January 24, 2024 09:31
@bkrmendy bkrmendy merged commit 8f13965 into master Jan 26, 2024
12 of 13 checks passed
@bkrmendy bkrmendy deleted the tests/pupeteer-test-logging branch January 26, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanparsons seanparsons seanparsons approved these changes

@gbalint gbalint gbalint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @seanparsons