Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are You Being Followed? 👀 #4785

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Are You Being Followed? 👀 #4785

merged 7 commits into from
Jan 23, 2024

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Jan 22, 2024 •
edited
Loading

Showing the bottom lozenge with the text “(1 person / 5 people) are following you” when the user is being followed.
Also deleting the <FollowerBadge/> on the user avatars who are following you (it still says if they are in their tooltip).

Screenshot 2024-01-22 at 7 59 18 PM Screenshot 2024-01-22 at 7 57 52 PM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 23, 2024 •
edited
Loading

Job #10005: Bundle Size — 62.36MiB (~+0.01%).

58b894b(current) vs 8f5e3ac master#10000(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10005		      Baseline
Job #10000
Regression  Initial JS 45.55MiB(~+0.01%) 45.54MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.9% 19.9%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4393 4393
No change  Duplicate Modules 474 474
Improvement  Duplicate Code 30.73%(-0.03%) 30.74%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #10005		      Baseline
Job #10000
Regression  JS 62.34MiB (~+0.01%) 62.34MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #10005 report View being-followed branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

4 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@lankaukk lankaukk marked this pull request as ready for review January 23, 2024 02:53
@lankaukk lankaukk merged commit ecf81db into master Jan 23, 2024
15 checks passed
@lankaukk lankaukk deleted the being-followed branch January 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@seanparsons seanparsons seanparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lankaukk @seanparsons @bkrmendy