Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove minimap from VS code #4784

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Remove minimap from VS code #4784

merged 4 commits into from
Jan 23, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Jan 22, 2024 •
edited
Loading

Problem:
Today we have the minimap toggled on by default in our vscode, and it's taking up precious real estate

Fix:
Add a patch to vscode.patch to disable the minimap by default

Before:
image

After:
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 22, 2024

Job #10002: Bundle Size — 62.35MiB (~-0.01%).

0b3b729(current) vs 8f5e3ac master#10000(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
Job #10002		      Baseline
Job #10000
Improvement  Initial JS 45.54MiB(~-0.01%) 45.54MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.9% 19.9%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4393 4393
No change  Duplicate Modules 474 474
No change  Duplicate Code 30.74% 30.74%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #10002		      Baseline
Job #10000
Improvement  JS 62.34MiB (~-0.01%) 62.34MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #10002 report View fix/minimap branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@liady liady merged commit 8ab79f3 into master Jan 23, 2024
16 checks passed
@liady liady deleted the fix/minimap branch January 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@seanparsons seanparsons seanparsons approved these changes

@gbalint gbalint Awaiting requested review from gbalint

@ruggi ruggi Awaiting requested review from ruggi

@balazsbajorics balazsbajorics Awaiting requested review from balazsbajorics

@maltenuhn maltenuhn Awaiting requested review from maltenuhn

@lankaukk lankaukk Awaiting requested review from lankaukk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liady @seanparsons @Rheeseyb @bkrmendy