Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cursor over comment threads #4720

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix cursor over comment threads #4720

merged 2 commits into from
Jan 11, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Jan 10, 2024

Fix #4718

Problem:

The mouse cursor is stuck into the comment bubble even when hovering comment threads and indicators.

Fix:

Fix that.

Before After
Kapture 2024-01-10 at 18 28 44 Kapture 2024-01-10 at 18 27 44

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 10, 2024

Job #9830: Bundle Size — 62.24MiB (~+0.01%).

e66af34(current) vs df0030c master#9829(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #9830		      Baseline
Job #9829
Regression  Initial JS 45.43MiB(~+0.01%) 45.43MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 19.89% 21.57%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4365 4365
No change  Duplicate Modules 472 472
No change  Duplicate Code 30.76% 30.76%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9830		      Baseline
Job #9829
Regression  JS 62.23MiB (~+0.01%) 62.23MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #9830 report View fix/comment-thread-cursors branch activity

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit 5aea0e9 into master Jan 11, 2024
14 checks passed
@ruggi ruggi deleted the fix/comment-thread-cursors branch January 11, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@seanparsons seanparsons seanparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix cursor over comment threads/indicators
3 participants
@ruggi @seanparsons @bkrmendy