Input/controls constraints for viewers #4713
Conversation
Job #9811: Bundle Size — 62.2MiB (~+0.01%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #9811 report View feat/disable-inspector-viewer branch activity |
|
Performance test results: |
# Conflicts: # editor/src/components/canvas/controls/new-canvas-controls.tsx # editor/src/core/performance/performance-regression-tests.spec.tsx
| @@ -686,6 +686,9 @@ export function handleKeyDown( | |||
| ) | |||
| }, | |||
| [INSERT_DIV_SHORTCUT]: () => { | |||
| if (!allowedToEdit) { | |||
There was a problem hiding this comment.
We have some other INSERT_ shortcuts that might need this check then
There was a problem hiding this comment.
indeed (not just insert_ but a lot more), but since changes cannot propagate, I added this here like we did for the text mode so the cursor does not change to a misleading crosshair, it's not meant to safeguard from the insertion per-se, as it's implicitly prevented by the collaboration
| @@ -717,3 +717,11 @@ export function useAllowedToEditProject(): boolean { | |||
| 'useAllowedToEditProject', | |||
| ) | |||
| } | |||
|
|
|||
| export function useIsMyProject(): boolean { | |||
There was a problem hiding this comment.
Does this clash with the baton passing work? I'm thinking that a lot of the places using this check should be instead using useAllowedToEditProject?
There was a problem hiding this comment.
I don't think it clashes, but it definitely makes it more granular. My take would be to wait that there are no baton-opened PRs to revisit and update
Fixes #4712
Problem:
Fix:
useIsMyProjecthook which returns whether the user is an owner of the current project, regardless of the baton