Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI job for collab test #4710

Merged
merged 4 commits into from
Jan 10, 2024
Merged

CI job for collab test #4710

merged 4 commits into from
Jan 10, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jan 9, 2024 •
edited
Loading

Description

This PR adds a CI job that runs the test for commenting.

Also

  • makes it possible to run this test locally, the same way as implemented in Configurable base url for comments test #4715
  • tweaks the test so that no hardcoded project name is necessary, the second browser navigates to the URL the first one is redirected to after the project is created.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 9, 2024 •
edited
Loading

Job #9812: Bundle Size — 62.2MiB (~+0.01%).

09f600d(current) vs df0030c master#9798(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #9812		      Baseline
Job #9798
Regression  Initial JS 45.4MiB(~+0.01%) 45.4MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.86% 19.86%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4362 4362
No change  Duplicate Modules 471 471
No change  Duplicate Code 30.75% 30.75%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9812		      Baseline
Job #9798
Regression  JS 62.19MiB (~+0.01%) 62.19MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #9812 report View tests/alice-bob-local branch activity

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy marked this pull request as ready for review January 10, 2024 10:14
Rheeseyb
Rheeseyb reviewed Jan 10, 2024
View reviewed changes
editor/src/components/editor/persistence/persistence.ts
@@ -100,7 +103,10 @@ export class PersistenceMachine {
)
this.queuedActions.push(...updateFileActions)
this.lastSavedTS = Date.now()
// TODO Show toasts after first server save of a previously local project
if (!this.projectUploadedToServer && event.source === 'server') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bkrmendy bkrmendy merged commit 758a0b4 into master Jan 10, 2024
15 checks passed
@bkrmendy bkrmendy deleted the tests/alice-bob-local branch January 10, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@seanparsons seanparsons seanparsons approved these changes

@gbalint gbalint Awaiting requested review from gbalint

@ruggi ruggi Awaiting requested review from ruggi

@balazsbajorics balazsbajorics Awaiting requested review from balazsbajorics

@liady liady Awaiting requested review from liady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @seanparsons @Rheeseyb