Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4707
Problem:
The editor performance degrades heavily when the comments section is open, worsening linearly with the number of threads.
Fix:
The root cause is the
useSelf
hook, used specifically inuseMyThreadReadStatus
, which causes constant re-renders. This is due to the fact thatuseSelf
includes the presence data, while we just need the user ID.So, this PR adds a new hook that only returns the user ID (from the editor state, we don't even need the LB hooks for this) and replaced it wherever
useSelf
was used inefficiently.Also, I replaced
useEditorState
with the ref variant for the canvas deltas used when clicking the threads in the sidebar.