Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved Comment Markers #4692

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Resolved Comment Markers #4692

merged 3 commits into from
Jan 5, 2024

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Jan 4, 2024 •
edited
Loading

Fixing up the styling for Resolved Comment Markers:

Screenshot 2024-01-04 at 3 38 00 PM Screenshot 2024-01-04 at 3 40 01 PM

Bonus Fix: the comment pop up now closes when you 'mark as unread'

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 4, 2024 •
edited
Loading

Job #9737: Bundle Size — 62.19MiB (~-0.01%).

8545cea(current) vs df0030c master#9731(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #9737		      Baseline
Job #9731
Regression  Initial JS 45.4MiB(~+0.01%) 45.4MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.86% 19.86%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4361 4361
No change  Duplicate Modules 470 470
No change  Duplicate Code 30.75% 30.75%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #9737		      Baseline
Job #9731
Improvement  JS 62.18MiB (~-0.01%) 62.18MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #9737 report View unread branch activity

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

Rheeseyb
Rheeseyb approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@Rheeseyb Rheeseyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Berci mentioned elsewhere, I too am unsure if marking the comment as "unread" should close it, but otherwise the code looks good to me

@lankaukk lankaukk merged commit 7fc0b7f into master Jan 5, 2024
11 checks passed
@lankaukk lankaukk deleted the unread branch January 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@gbalint gbalint gbalint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lankaukk @gbalint @Rheeseyb @bkrmendy